The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Followed/related to #1900962: Use Config Entity query for views_get_applicable_views(). We can use this for these functions pretty easily.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 1901076-10.patch | 1016 bytes | damiankloip |
| #10 | interdiff.txt | 790 bytes | damiankloip |
| #1 | 1901076-1.patch | 1020 bytes | damiankloip |
| d8.config-query-enabled-disabled.patch | 916 bytes | damiankloip |
Comments
Comment #1
damiankloip commentedOops, we want to return entities.
Comment #2
dawehnerRTBC once it's green. YEAH
Comment #4
dawehner#1: 1901076-1.patch queued for re-testing.
Comment #5
damiankloip commentedThis was rtbc already. It's a small patch...
Comment #6
damiankloip commented#1: 1901076-1.patch queued for re-testing.
Comment #8
tstoecklerSuppose this needs to be updated for the new status property on views, i.e.
(and vice-versa).
Comment #9
damiankloip commentedYep. Just wanted to make sure ;) I'll reroll this.
Comment #10
damiankloip commentedgood to go.
Comment #11
damiankloip commentedComment #12
dawehnerBack to RTBC if the patch got green.
Comment #14
tstoecklerQuick question as a total Views noob: Should we remove the 'views_view_is_(en|dis)abled()' functions as well in this patch or are they use elsewhere? Since they seem to take a $view object, it seems they could just do $view->enabled() now, but I don't know how often that is currently used, i.e. whether it would make sense to do that in a follow-up.
Comment #15
dawehner#10: 1901076-10.patch queued for re-testing.
Comment #16
tstoecklerCrosspost with the machine...
Comment #17
tstoecklerAgain?! Back to RTBC for the bot.
Comment #18
dawehnerLet's do that in a follow up, but I agree with you that we don't need all those custom functions, people will be used to check the status directly on the entity.
Comment #19
tim.plunkettI believe the procedural functions are used by Drush, but now that Views is in core, they can handle that. We should open a Drush issue to coordinate their removal (in a follow-up)
Comment #20
damiankloip commentedYeah. The is enabled and disabled methods were just wrappers added for drush. So we can put anything we need in there now. Good plan!
Comment #21
webchickCommitted to 8.x, will push after testbot calms down. Thanks!