A case of !empty being better than isset; right now it's calling delete for src = 'node/nid 'on insert of that nodes w/o paths (since path is set to an empty string, not null).

CommentFileSizeAuthor
drupal_path_nodeapi_insert.patch535 byteshefox

Comments

areke’s picture

areke commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

The path is a string, so there's a possibility an empty string could be passed into the function, which would mean the alias could have been set already. Since !empty will check if the string is set AND has an actual value, it's better to use that. The patch applies cleanly, so it looks good. Thank you!

Status: Reviewed & tested by the community » Needs work

The last submitted patch, drupal_path_nodeapi_insert.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.