Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
database system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
27 Oct 2007 at 15:09 UTC
Updated:
13 Dec 2007 at 06:58 UTC
When you look at drupal_install_schema(), you see:
function drupal_install_schema($module) {
$schema = drupal_get_schema_unprocessed($module);
_drupal_initialize_schema($module, $schema);
$ret = array();
foreach ($schema as $name => $table) {
db_create_table($ret, $name, $table);
}
}
You'll notice that it collects the return values from creating the database tables, but it doesn't do anything with them. Would it make more sense to return what was collected from creating the tables? return $ret; would make sense. The same can be done with drupal_uninstall_schema()... See attached patch.
| Comment | File | Size | Author |
|---|---|---|---|
| drupal_install_schema_return_value_1.patch | 1.11 KB | robloach |
Comments
Comment #1
dries commentedGood question. I don't think we should do anything with it, unless there is an actual use case for it. I'm going to mark this "won't fix" but feel free to re-open the issue when you have a use case. Thanks Rob.
Comment #2
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #3
panchoJust a notice: a similar patch by bjaspan has been committed in November 2007 (see #190899)