comment_reply() does a comment_load() on the parent comment, and then does a couple extra stuff (including calling field_attach_load()) that are already done as part of the load.

That's a leftover from D7, where the parent comment was not loaded with comment_load() but with a manual db query (got changed in this D8 commit).

CommentFileSizeAuthor
#1 comment_reply-f_a_load-1870790-1.patch696 bytesyched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new comment_reply-f_a_load-1870790-1.patch696 bytes
yched’s picture

yched commented

#1: comment_reply-f_a_load-1870790-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, comment_reply-f_a_load-1870790-1.patch, failed testing.

yched’s picture

yched commented
Status: Needs work » Fixed

Got fixed meanwhile, it seems...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.