Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#10 | statistics-guzzle-1867382-10.patch | 8.29 KB | Berdir |
#9 | statistics-guzzle-1867382-9.patch | 8.38 KB | Sutharsan |
#1 | statistics-guzzle-1867382-1.patch | 8.76 KB | Berdir |
Comments
Comment #1
BerdirAnother simple conversion. Not sure why we specify the timeout explicitly, but I kept it for the moment. Might also be useful to ave a helper method for those calls but that would require a common base class.
Put the client config in setUp() if there was more than one call and directly in the code for those that only do a single call.
Comment #2
rbayliss CreditAttribution: rbayliss commentedLooks good to me.
Comment #3
timmillwood#1: statistics-guzzle-1867382-1.patch queued for re-testing.
Comment #4
timmillwoodLooks good.
Comment #5
Dries CreditAttribution: Dries commentedAsking for a retest. Patch doesn't seem to apply.
Comment #6
Dries CreditAttribution: Dries commented#1: statistics-guzzle-1867382-1.patch queued for re-testing.
Comment #8
YesCT CreditAttribution: YesCT commentedMight work as a novice issue to reroll this (helpful doc on how to do rerolls http://drupal.org/patch/reroll)
Comment #9
Sutharsan CreditAttribution: Sutharsan commentedPatch rerolled.
Comment #10
BerdirAnother re-roll, to use Drupal::httpClient()
Comment #11
YesCT CreditAttribution: YesCT commentedstandards-wise this looks good.
Comment #12
alexpottCommitted e45b1a7 and pushed to 8.x. Thanks!