Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Dec 2012 at 17:42 UTC
Updated:
29 Jul 2014 at 21:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
damiankloip commentedComment #2
damiankloip commentedOk, changed the title and the patch to reflect that.
Comment #3
damiankloip commentedAnd the ViewExecutableTest needs that change too.
Comment #4
dawehnerLet's "Force" it :)
Should be better setUsesAJAX?
What about making it protected now?
Comment #5
damiankloip commentedAll good points. Also cast the setUsesAJAX value to a bool. I know you don't care but do we trust people?! ;)
Comment #6
dawehnerWhat about documenting the parameter as boolean?
I guess we should use ViewExecuteable::setUsesAJAX here (maybe even with full namespace).
Comment #7
damiankloip commentedYep, good point. Let's change that too.
Comment #8
damiankloip commentedOops, and the diff.
Comment #9
dawehnerIt adds test coverage, has proper documentation etc.
PS: you could nitpick $use_ajax -> $uses_ajax
Comment #10
damiankloip commentedI actually thought about leaving this as use_ajax, but don't mind. I guess uses makes a bit more sense, to match the method.
Don't you just love small issues that have lots of patches ;)
Comment #12
damiankloip commentedOops, sorry.
Comment #13
dawehnerPerfect, thank you for all the small changes!
Comment #14
catchsetUseAjax() and setUsesAjax() are strange method names. Could it be at least get/set? Is 'uses' the best word here?
Comment #15
damiankloip commentedOK, from a brief IRC discussion; let's change this to ajaxEnabled().
Comment #16
damiankloip commentedSorry, missed one in views.module.
Comment #17
damiankloip commentedComment #18
dawehnerTo be honest, it's confusing to both have isAJAXEnabled on the display but also AjaxEnabled, at least we should use AJAXEnabled, but i really vote for more consistency. Either the view or the display uses ajax. This seems not to be rocket science.
Comment #19
damiankloip commentedYou are right, this should in theory be easy :) and consistency is king. I have changed isAJAXEnabled to ajaxEnabled to we have the same on both ViewExecutable and DisplayPluginBase.
Comment #20
dawehnerOh didn't we agreed in Paris to always use uppercase for shortcuts?
Comment #21
damiankloip commentedYeah, we did indeed :) But I spoke to catch/timplunkett and they wanted ajaxEnabled I think...
Comment #22
damiankloip commentedRe rolled.
Comment #24
damiankloip commentedFFS
Comment #25
damiankloip commented#22: 1866910-22.patch queued for re-testing.
Comment #26
dawehnerOkay, so this looks good now!
Comment #27
catchThere's an issue somewhere about ajax vs. AJAX in method names, I prefer the latter (at least when it's something like testCss() which just looks silly), but I think at the moment it's just camel case in core.
Committed/pushed this to 8.x.