There are various trailing comments in taxonomy.admin.inc, arguably some of them can be deleted as they are fairly redundant, but alternatively they need to be moved.

CommentFileSizeAuthor
#7 taxonomy_comments-1862390-7.patch2.29 KBbillk2
#6 taxo-comments-1862390-6.patch2.29 KBoriol_e9g
#2 1862390-taxonomy_comments-drupal8-2.patch2.36 KBACF

Comments

ACF’s picture

ACF commented
Title: Remove trailing comments from taxonomy.admin.inc. » Fix trailing comments from taxonomy.admin.inc.
ACF’s picture

ACF commented
Status: Active » Needs review
Issue tags: +Novice
StatusFileSize
new 1862390-taxonomy_comments-drupal8-2.patch2.36 KB

A go at a fix. I've removed the trailing comments after the variables cause I think that the variable names are self explanatory.

billk2’s picture

billk2 commented
Issue tags: -Documentation, -Novice

#2: 1862390-taxonomy_comments-drupal8-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Documentation, +Novice

The last submitted patch, 1862390-taxonomy_comments-drupal8-2.patch, failed testing.

linl’s picture

linl commented
Issue tags: +Needs reroll
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new taxo-comments-1862390-6.patch2.29 KB
billk2’s picture

billk2 commented
StatusFileSize
new taxonomy_comments-1862390-7.patch2.29 KB

Rerolled to current 8.x

billk2’s picture

billk2 commented

Sorry. Just noticed you've already rerolled.

Status: Needs review » Needs work
Issue tags: -Documentation, -Novice

The last submitted patch, taxonomy_comments-1862390-7.patch, failed testing.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review
Issue tags: +Documentation, +Novice

#6: taxo-comments-1862390-6.patch queued for re-testing.

linl’s picture

linl commented
Status: Needs review » Reviewed & tested by the community

Looks good. Patch in #6 RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: taxonomy.module » documentation
Issue tags: -Documentation +Coding standards
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Rather than rerolling here due to the almost certainly unrelated random test failure, can someone upload a new copy of the patch? That way we can preserve the test failure log. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs work » Needs review

Never mind, just a DB glitch on test bot. I'll hit retest.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

#7: taxonomy_comments-1862390-7.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Fixed

Thanks! This was RTBC before all the testbot glitches, and has now passed. Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.