module_implements already checks if a module implements a hook, and _db_rewrite_sql is using that, so the extra function exists in module_invoke is unnecessary so more performant to just do $function = $module . '_db_rewrite_sql' and should be no-negative-impact change

CommentFileSizeAuthor
drupal-db_rewrite_sql-moduke_invoke.patch697 byteshefox

Comments

hefox’s picture

Title: don't use moduke_invoke for db_rewrite_sql (unnecessary function_exists) » don't use module_invoke for db_rewrite_sql (unnecessary function_exists)
mdupont’s picture

Issue summary: View changes
Status: Needs review » Closed (works as designed)

This is a case of following coding standards, using an interface (module_invoke()) instead of a specific implementation of it ($module . '_'. $hook). Closing this issue then.