Make $values optional on entity_create

Love this. Simple and good: removes code, mostly. Ready pending on bot approval.

#1: drupal-1857442-1.patch queued for re-testing.

Been a while, patch needs rerolling.

+++ b/core/includes/entity.inc
@@ -254,16 +254,16 @@ function entity_delete_multiple($entity_type, array $ids) {
+ *   (optional) An array of values to set, keyed by property name. If the entity type has
...
- *   An array of values to set, keyed by property name. If the entity type has

This should wrap after 80 characters (i.e. after "entity").

Rerolled. Fixed comments as per #10, ensured that all *StorageController classes have a default $values = array(), ensured that all calls to entity_create() no longer pass an empty array() where one isn't needed.

11: 1857442-entity_create-optional-values-11.patch queued for re-testing.

Rerolled.

nice work.

grep -Rn "entity_create('.*', array())" * | wc -l
result : 0

RTBC

14: 1857442-entity_create-optional-values-14.patch queued for re-testing.

Rerolled.

Missed FieldableEntityStorageControllerBase::create(), rerolled again.

No longer applied, rerolled.

Looks fine, will conflict again with https://drupal.org/node/1867228, but so be it ;)

Nice one! This makes the calling code significantly cleaner.

Committed and pushed to 8.x. Thanks!