DrupalKernel in DrupalUnitTestBase is dumped [#1849118]

Comment	File	Size	Author
#7	drupal8.dutb-kernel.7.patch	773 bytes	sun

	drupal8.dutb-kernel.0.patch	719 bytes	sun

Comment #1

katbailey CreditAttribution: katbailey commented 24 November 2012 at 05:13

Status:

Needs review

» Reviewed & tested by the community

Word.

Log in or register to post comments

Comment #2

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 27 November 2012 at 04:34

Status:

Reviewed & tested by the community

» Needs work

Since I have no idea what in the heck "dumping" means, and still don't after having trawled through DrupalKernel.php (I guess it takes the contents of the container and writes it out to disk. Why..?), could we get a one-liner comment that helps the next person understand why FALSE is passed here, since the details in this issue certainly won't help them discern this. :D

Log in or register to post comments

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 27 November 2012 at 04:53

Status:

Needs work

» Reviewed & tested by the community

Sorry, but I think this is the wrong issue/place to discuss or document that.

DrupalUnitTestBase only uses this API, and this patch only adjusts the API call. The additional FALSE flag is passed to prevent the kernel from compiling and dumping its container when executing a DrupalUnitTest. That is unnecessary, since the entire test is executed in memory, which means that the dumped kernel/container will not be read again later on.

@chx created #1850438: Establish DrupalKernel argument good practices for similar reasons, the $allowDumping argument could be documented + patched in there, too.

If that issue not sufficient (possible), then I'd suggest to create a dedicated issue along the lines of "What the heck is a DrupalKernel, where is it, what does it do, what are all of those arguments, what means compiling, and what the heck means dumping?" ;-)

Log in or register to post comments

Comment #4

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 27 November 2012 at 05:01

Status:

Reviewed & tested by the community

» Needs review

No, what we need then is basically this:

     // Bootstrap the kernel.
     // Dumping is unnecessary, since the entire test is executed in memory, so  the dumped kernel/container will not be read again later on.
     +    $this->kernel = new DrupalKernel('testing', TRUE, drupal_classloader(), FALSE);

(give or take an 80 character wrap)

If that's the proper comment I can just fix it on commit, but I've literally no idea because the documentation in DrupalKernel around this is so poor (which, yes, has nothing to do with this issue).