disabling translation of fields with data stalls and does not work [#1833108]

Follow up for #1831530: Entity translation UI in core (part 2)

Problem/Motivation

disabling translation of fields (with content) stalls and does not disable

Proposed resolution

none yet.

Remaining tasks

DONE reproduce/document steps to reproduce #1833108-3: disabling translation of fields with data stalls and does not work
fix the bug
create a simple test

User interface changes

no changes needed.

API changes

no api changes needed.

Comment	File	Size	Author
#3	how_to_enable_translation_field_for_empty_field.png	25.78 KB	-enzo-
#3	how_to_enable_translation_field_for_field_with_data.png	26.87 KB	-enzo-
#3	how_to_disable_translation_for_entity_with_data.png	26.76 KB	-enzo-
#3	batch_error_trying_to_disable_translation_entity.png	23.04 KB	-enzo-

Comments

Comment #1

yesct commented 6 November 2012 at 07:36

This worked during most of the original et-ui issue, and so it might not actually be a bug.
Check to see if it's reproducible.
See if there is a test for disabling.

Comment #2

-enzo- commented 6 November 2012 at 18:40

Assigned:

Unassigned

» -enzo-

I just reproduce this error, please give me few minutes to write down the steps by step to reproduce the error

Comment #3

-enzo- commented 6 November 2012 at 19:00

Status	File	Size
new	batch_error_trying_to_disable_translation_entity.png	23.04 KB
new	how_to_disable_translation_for_entity_with_data.png	26.76 KB
new	how_to_enable_translation_field_for_field_with_data.png	26.87 KB
new	how_to_enable_translation_field_for_empty_field.png	25.78 KB

How to reproduce the error:

1. Create any entity field and enable translation. the user interface will looks different if the entiry is empty or not

Enable translation for empty entity

Enable translation for entity with data

how_to_enable_translation_field_for_field_with_data.png

2. If your entity is empty create some content to add a translation.

3. Disable the entity translation

After click in disable translation you will get a batch process, but the process get stucked at 25% as you can see in the following images

If you stop the process and check the translations, all translations are gone. So if you try again to disable the translation the process now is completed without any problems.

Comment #4

-enzo- commented 6 November 2012 at 19:07

Assigned:

-enzo-

» Unassigned

Comment #5

-enzo- commented 6 November 2012 at 19:08

Issue tags:

-Novice

+Needs tests

Comment #6

yesct commented 8 November 2012 at 08:08

@plach I'm hoping you can take a look at this one.
It feels like something where you might look at it and think of where the problem might be coming from. Versus someone debugging for a long time to find it. What do you think? [edit: If you have a hunch, post some hints and we can find someone to look in the direction you suggest.]

Comment #7

plach

he/him

Italian

Venezia

commented 9 November 2012 at 00:13

Status:

Active

» Postponed (maintainer needs more info)

I think this may be related to the EFQv2 conversion: basically all the code in translation_entity.admin.inc was converted from a single query looking for all the field values belonging to any entity_type to separate queries, one for each entity type which the field being converted is attached to. The logic is a bit trickier now, but this shouldn't hard to fix once we have the steps to reproduce it reliably. I could not yet.

I'd like to avoid spending too much time on this since, as I said many times, all the code in translation_entity.admin.inc is going to be blown away once Field API and Entity Field API are finally merged.