Most functions that implement / override something from CacheArray are wrong documented.

CommentFileSizeAuthor
#5 1831702_doc_implements_5.patch3.1 KBmiro_dietiker
#1 1831702_doc_implements.patch3.11 KBmiro_dietiker

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new 1831702_doc_implements.patch3.11 KB

First try.
Nonfunctional!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: Unassigned » jhodgdon
Status: Needs review » Reviewed & tested by the community

Thanks! All of those changes are correct. I'll get this committed soon.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

This patch no longer applies, probably due to just committing your other patch on #1831646: Document rename DrupalCacheArray to CacheArray -- needs a reroll. Thanks!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new 1831702_doc_implements_5.patch3.1 KB

Providing patch with new version.
Just replaced DrupalCacheArray with CacheArray.

Hope, fast forward and this can be fixed now.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: Unassigned » jhodgdon
Status: Needs review » Reviewed & tested by the community

Thanks! I confirmed that the new patch is the same as the old except for the context (i.e. the result is the same but it will actually apply). I'll get it committed shortly.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks again - committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.