Since trigger module was removed, a lot of actions functionality is un-tested. This is what happens when we rely so much on implicit test coverage :(

This issue is a specific follow-up to #1797206: Actions module has variable name conflict which breaks tests, we shouldn't mark it fiixed until reverting that patch causes the new tests to fail, however testing every possible other aspect of actions module is not required.

Comments

sun’s picture

Title: Improve test coverage for action module » Add test coverage for Actions module
Issue tags: +Needs tests

There are two main aspects to test:

1) Low-level API of executing actions (i.e., actions_do()).

2) Configuration/UI for actions.

Ideally also 3) Testing of individual actions (hopefully soon plugins), but those should rather be unit tests, detached from the actual action API.

2) should be relatively straightforward. Just go through the entire available UI and verify all possible operations.

1), however, is pretty advanced. Especially, because there is no way at all in core to trigger the operation. This likely means that it should be a unit test as well, since all we can reasonably do is to verify that certain input leads to certain output/actions.

yesct’s picture

Maybe a small partial patch that does just one, posted by someone experienced with tests, would be enough of a spring board that someone could take over from there and expand it to do more.

Adding link to contributor task doc on how to add tests too in case that helps someone take as tab at this: http://drupal.org/node/1468170
For someone new: dont feel like you have to do it all. It's ok to try just a part and post what you have so far. Sometimes that really helps.

dags’s picture

Assigned: Unassigned » dags

Working on writing a single test.

dags’s picture

Assigned: dags » Unassigned
Status: Active » Closed (duplicate)