Sub-issue of #1190252: [573] Use csslint as a weapon to beat the crappy CSS out of Drupal core

Inline with the CSS cleanup efforts of the HTML5 initiative, using CSSLint at http://csslint.net provides a quick way to code-sniff our css and tweak styles.

  1. Copy and paste the the stylesheet(s) below into the css lint tool at http://csslint.net and test.
  2. Fix any warnings or errors the tool finds.
  3. Patch Drupal 8 locally and make sure the css changes have not broken anything visually.
  4. Create patch and upload for the testbot.

Files: modules/simpletest/simpletest.css

CommentFileSizeAuthor
#1 1663164-simpletest-css-cleanup.patch2.68 KBdroplet

Comments

droplet’s picture

Status: Active » Needs work
StatusFileSize
new2.68 KB

This is very bad and I can't find any usage example.

@@ -39,46 +39,46 @@ div.message > div.item-list {
   font-weight: normal;
 }
droplet’s picture

+++ b/core/modules/simpletest/simpletest.cssundefined
@@ -39,46 +39,46 @@ div.message > div.item-list {
-tr.simpletest-pass.odd {
+.simpletest-pass.odd {
   background-color: #b6ffb6;
 }
-tr.simpletest-pass.even {
+.simpletest-pass.even {
   background-color: #9bff9b;
 }
-tr.simpletest-fail.odd {
+.simpletest-fail.odd {
   background-color: #ffc9c9;
 }
-tr.simpletest-fail.even {
+.simpletest-fail.even {
   background-color: #ffacac;
 }
-tr.simpletest-exception.odd {
+.simpletest-exception.odd {
   background-color: #f4ea71;
 }
-tr.simpletest-exception.even {
+.simpletest-exception.even {
   background-color: #f5e742;
 }
-tr.simpletest-debug.odd {
+.simpletest-debug.odd {
   background-color: #eee;
 }
-tr.simpletest-debug.even {
+.simpletest-debug.even {
   background-color: #fff;
 }

http://drupal.org/node/1649780

webchick’s picture

Status: Needs work » Closed (duplicate)

Marking as a duplicate of #1217040: Clean up the CSS for Simpletest module, which is older and has a patch.