Now $entity_type can be retrieved from $entity, so it is no longer necessary.

CommentFileSizeAuthor
#3 1643362-3.patch509 bytesswentel

Comments

dawehner’s picture

dawehner
Primary language German
commented

The question is: do you want to have a single uri callback for multiple entity types?

jcisio’s picture

jcisio commented

I'm not sure I get it. Currently Entity::uri returns an array that contain $entity, so it does not needs to return $entity->entityType because it is redundant.

swentel’s picture

swentel commented
Status: Active » Needs review
StatusFileSize
new 1643362-3.patch509 bytes

It is kind of redundant indeed.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Yeah if you really want you can always get the entity type from the entity itself.

Additional this feature was never considered to be important given that there is no test coverage for that in core.

jcisio’s picture

jcisio commented

Exactly!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Fixed

Committed ad0a71a and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.