Remove "create forum topics" when only forum containers visible

This can either be seen as a usability bug or as a feature request.

I propose the following patch to forum.module to replace the "Post new forum topic" link with "Select a forum below" on pages where only forum containers are shown. Look for line 901 in forum.module, function theme_forum_display() (Drupal 5.2, works also in Drupal 5.1):

    if (user_access('create forum topics')) {
      // [ShutterFreak] replaced 1 line:
      // $output .= '<li>'. l(t('Post new forum topic.'), "node/add/forum/$tid") .'</li>';
      // with the following 5 lines:
      if (!in_array($tid, variable_get('forum_containers', array())) && ($tid != 0)) {
         $output .= '<li>'. l(t('Post new forum topic.'), "node/add/forum/$tid") .'</li>';
      } else {
        $output .= '<li>'. t('Select a forum below.') .'</li>';
      }
      // [ShutterFreak] End of added lines
    }

I got my inspiration from the og_forum module.

Best regards,

Olivier