Screen shot 1: http://i12.tinypic.com/5zqea12.png
...because of:
.form-button, .form-submit {
margin: 2em 0.5em 1em 0pt;
}
Screen shot 2: http://i10.tinypic.com/5ytxgdy.png
Patch adds the following to system.css:
.container-inline .form-button, .container-inline .form-submit {
margin: 0;
}[And, does the component for issue tracker need an update(from drupal.css to CSS styles)?]
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | drupal.container-inline.8.patch | 2.41 KB | sun |
| #6 | drupal.container-inline.6.patch | 3.33 KB | sun |
| D6-b-inline-button-margin.patch | 510 bytes | Gurpartap Singh |
Comments
Comment #1
dries commentedThis doesn't seem to be a problem for some other forms, such as the various search forms (content search, user search, patch search). This could mean that these modules have their own custom CSS snippets to correct this behavior. We'll want to investigate this a bit more, and clean up the CSS if possible.
Comment #2
maartenvg commentedHow is this going? I'm planning to use the .container-inline class in a module I'm updating, and came across this bug.
Most modules in core are fixed by this part of garland's style.css:
That's why for instance searches and every form inside a fieldset shows its form-submit && form-button properly, but comment.module isn't because it hasn't got a fieldset or a table around it.
It wouldn't be a problem for me to add some custom css to the module, but as far as I can see every form-submit & form-button inside a .container-inline should not have a top or bottom margin. Therefore a (small) fix in core might be better.
I opt for Gurpartap's solution, maybe for an later 5.x release as well.
Comment #3
sun.core commentedMoving "drupal.css" component issues to "markup".
Comment #4
sunComment #5
jacineWhat are we supposed to test this on? Given the fact that the last reply was 3 years ago, I wonder if this is an issue at all anymore. I don't see any option to turn on comment display options anymore. Seems like it's gone from D7. Also, if the issue is only happening in Garland, it doesn't belong in this component.
Comment #6
sunSlightly re-purposing this issue.
1) Labels within .container-inline are currently overridden by system.theme.css
2) system.theme.css does not seem to account for .form-actions yet, and also not for .form-actions in combination with .container-inline.
Attached patch fixes that + Garland accordingly. Bartik seems to be fine. Didn't test others.
Test pages/forms:
node/1/delete (i.e., any confirmation form)
admin/config/regional/translate/translate (Locale module)
admin/config/system/actions
admin/content/comment
Comment #7
jacineI tested with Stark and the others. Looks good to me.
Comment #8
sunOnly removed the PHP hunk, which duplicated #922634: Odd form actions in confirm_form()
Comment #9
dries commentedCommitted to CVS HEAD. Thanks.
Comment #10
sunThanks! This patch revealed some very odd CSS styles in SimpleTest module, to be fixed over in #924158: SimpleTest test selection form markup/styling broken