Some API links are not converted into proper links [#1610342]

Probably it's some duplicate, but...

Some of the links to API haven't got converted to proper links.

Example:
http://api.drupal.org/api/drupal/includes!database!database.inc/constant...

Working examples:
http://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Database%2...
http://api.drupal.org/api/drupal/includes%21database%21database.inc/cons...
http://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Database%2...

Comments

Comment #1

kingandy

he/him

commented 31 May 2012 at 09:59

Can you expand on "haven't got converted to proper links"? If I read this right, the issue is more about Drupal.org's URL-to-link filter than a.d.o's link formatting.

Filter tests:
http://drupal.org
http://drupal.org!
http://drupal.org/!
http://drupal.org/home!link
http://drupal.org/home?what!link

Comment #2

kingandy

he/him

commented 31 May 2012 at 10:01

Yeah, looks like it's passing on URLs with exclamation marks inside them.

Comment #3

kenorb commented 31 May 2012 at 10:35

I didn't edit those URLs.
Those URLs are indexed by Google.

1. Type in Google i.e.:
Database::openConnection
or:
includes!database!database.inc
2. Click on the link with exclamation mark, i.e.
http://api.drupal.org/api/drupal/includes!database!database.inc/function...
and then paste it here.

Comment #4

kingandy

he/him

commented 31 May 2012 at 10:50

Project:	Drupal.org site moderators	» Drupal core
Version:		» 6.26
Component:	API.drupal.org	» filter.module

The URL is fine, Google is correctly interpreting %21 as the ! character. The problem is, after you paste it into a Drupal content area, the "Web page addresses ... turn into links automatically" filter is not recognising it as a web page address because there is an exclamation mark in it.

Moving this over to the filter.module queue. For what it's worth, this appears to have been fixed in Drupal 7.x ... I don't know if this warrants a backport?