generating errors on all pages.

CommentFileSizeAuthor
#8 drupal-stark_region_definitions-1591474-8.patch494 bytesrooby
#6 missing_regions-1591474-6.patch524 bytesUllas Prabhakar
#4 missing_regions-1591474-4.patch490 bytesUllas Prabhakar
#1 missing_regions-1591474-1.patch618 bytesjenlampton

Comments

jenlampton’s picture

jenlampton
she / her
commented
StatusFileSize
new missing_regions-1591474-1.patch618 bytes

patch

jenlampton’s picture

jenlampton
she / her
commented
Status: Active » Needs review

changing status

Ullas Prabhakar’s picture

Ullas Prabhakar commented

Blocks page displays regions even without patch. The patch doesnot work as it is written for .info file instead of .info.yml.

Ullas Prabhakar’s picture

Ullas Prabhakar commented
StatusFileSize
new missing_regions-1591474-4.patch490 bytes

Re-rolling the patch for .info.yml file

Status: Needs review » Needs work

The last submitted patch, missing_regions-1591474-4.patch, failed testing.

Ullas Prabhakar’s picture

Ullas Prabhakar commented
Status: Needs work » Needs review
StatusFileSize
new missing_regions-1591474-6.patch524 bytes

Re-rolled with correct yml format

Status: Needs review » Needs work

The last submitted patch, missing_regions-1591474-6.patch, failed testing.

rooby’s picture

rooby commented
Status: Needs work » Needs review
StatusFileSize
new drupal-stark_region_definitions-1591474-8.patch494 bytes

This one is like #6 but has the footer region instead of the featured region and keeps the newline at the end of the file.

jaredsmith’s picture

jaredsmith commented
Status: Needs review » Reviewed & tested by the community

Patch #8 reviewed and tested at the March 28th DC Drupal Meetup Issue Sprint. It looks good.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests

If there are errors being generated on all pages, we need test coverage here.
Also, _system_rebuild_theme_data() has code specifically to fill in these values, they're intended to be optional.

dcrocks’s picture

dcrocks commented

Where are these errors? I'm not seeing any when I run stark.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Closed (cannot reproduce)

Yeah, if this wasn't working, there'd be a bug in _system_rebuild_theme_data() anyway, a theme isn't required to specify regions.