Selectors clean-up: block

Is that normal you loose the context parameter of the attach() function?

why introduce CONTEXT at beginning ? only for performance? Seems like 95%+ of time, "context = document" ?

loose context implicit could not changing the scope..
valid HTML page, ID is unique. But .classA #id, .classB #id are difference.

context is more than that, it also avoid potential duplicate calls when you attach back a result coming from AJAX request, or crafted DOM sections. It's cleaner architecturally since you always work in an encaspuled context.

But, in that specific case what I told has no sense and I agree with nod_, there is no need for context since it's working on ids, it just removes the unused variable from scope.

I didn't tested myself on my browser, but I dare to trust you about this one, the patch seems straightfoward enough :)

Of course, if there is someone else to test with IE which I can't do, working fine with FF 11 and Chromium 18

@nod_ Yes I ended up testing after 2 seconds I clicked the submit button.

Also working with Epiphany (now known as Web since Gnome 3.4) but not working in konqueror 4.8.3, but I'm not sure this is the JS for konqueror, since no summary at all anywhere seems to show up.

Looks good to me, committed/pushed to 8.x.

Investigate if adding basic events and detach makes sense, as described in #1763812: [META] Provide complete attach/detach with basic events

looks like it could use a detach?

Small patch for lighter js and some performance clean up (remove var duplication and other).

+++ b/core/modules/block/block.jsundefined
@@ -26,9 +26,9 @@ Drupal.behaviors.blockSettingsSummary = {
-    $('#edit-visibility-node-type').drupalSetSummary(checkboxesSummary);
-    $('#edit-visibility-language').drupalSetSummary(checkboxesSummary);
-    $('#edit-visibility-role').drupalSetSummary(checkboxesSummary);
+    $('#edit-visibility-node-type, ¶
+      #edit-visibility-language, ¶
+      #edit-visibility-role').drupalSetSummary(checkboxesSummary);

To me it seems only these 3 lines is needed.

Assigned to myself so that I can work on it.

Hi,
This is my first time working with Drupal as I am still in high school and have only recently learnt about working in open source. I have never coded anything using JavaScript until two days ago so my level of understanding is quite basic.

Attached is a patch that addresses the concerns in #16

Re-rolled with above suggestions.

Have applied the patch to 8.x and can confirm there are no errors on the block layout screens coming from block.js (there is another unrelated error coming from escapeAdmin.js:

Uncaught TypeError: Cannot read property 'currentPathIsAdmin' of undefined escapeAdmin.js?v=8.0-dev:17
(anonymous function) escapeAdmin.js?v=8.0-dev:17
(anonymous function) escapeAdmin.js?v=8.0-dev:39

There appears to be an issue already open at #2169299: Fix "Cannot read property 'currentPathIsAdmin' of undefined" error in escapeAdmin.js for this.

This addresses @nod_'s concerns at #19, and I think makes an improvement to the readability of the code.

Happy to RTBC this patch.

Committed and pushed to 8.x. Thanks!