convert taxonomy module to deletion API [#154128]

attached patch makes taxonomy module work w/ the deletion API. a few things:

this patch is waiting on http://drupal.org/node/154046 -- so you'll need to apply that to test this properly.
the deletion type names i picked where 'vocabulary' and 'term', for vocabulary and term, respectively -- seems straightforward enough... :)
i've removed a call to taxonomy_del_term() that was in taxonomy_save_term(). it was there to delete a term if it was saved w/o a name, but name is a required field. since performing that kind of deletion isn't in line w/ dapi, and the use case was, well, useless -- i removed it.

Comment	File	Size	Author
#1	dapi_taxo_0.patch	7.77 KB	hunmonk
	dapi_taxo.patch	7.66 KB	hunmonk

Comments

Comment #1

hunmonk commented 24 June 2007 at 16:03

Status	File	Size
new	dapi_taxo_0.patch	7.77 KB

confirm form patch has been committed, so here's the updated version of this conversion. tested some vocab and term deletions, and all appears to be well.

Comment #2

drewish commented 26 June 2007 at 15:49

Status:

Needs review

» Reviewed & tested by the community

I ran into :

notice: Trying to get property of non-object in modules/taxonomy/taxonomy.module on line 735.

and

* notice: Undefined index: op in modules/taxonomy/taxonomy.module on line 1429.
* notice: Undefined index: confirm in modules/taxonomy/taxonomy.module on line 1429.
* notice: Trying to get property of non-object in modules/taxonomy/taxonomy.module on line 422.
* notice: Trying to get property of non-object in modules/taxonomy/taxonomy.module on line 440.
* notice: Undefined variable: synonyms in modules/taxonomy/taxonomy.module on line 1016.
* notice: Trying to get property of non-object in modules/taxonomy/taxonomy.module on line 456.

but I don't think it's related to this patch. All the deletion looks good.