The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.We are currently listing all themes in the blocks administration and for every theme we have a tab named 'themeX settings'. If someone has many themes installed/enabled the tabs are quickly getting confusing. I suggest to remove the word 'settings' from the title. It makes the list much clearer without loosing context. Attached is a 'micro' patch which removes the word 'settings' (and adds a missing '$form_state').
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | block_settings_title2.patch | 833 bytes | profix898 |
| block_settings_title.patch | 1003 bytes | profix898 |
Comments
Comment #1
moshe weitzman commented+1 to removing that word 'settings'.
but your change to block_admin_display() does not look right. it is called from block_menu() with: page arguments' => array('block_admin_display', $key),
that means that $key will be first arg. also, you can simplify $title in that menu declaration and eliminate 'title arguments'
Comment #2
profix898 commentedOK. Simplified $title (and eliminated 'title arguments').
As for the change to block_admin_display(). I was not sure there either. $key should be the first arguments, yes, but actually it is not. $form_state is passed as first arguments and $key comes second. Without the 'fix' the themes in blocks administration dont switch, what means you cant configure blocks per theme (and it generates a warning). Might be a bug in the FAPI3 section though ... I removed that piece from the patch for now. Thanks.
Comment #3
dmitrig01 commented-1. Setting the title to the theme name is really confusing
Comment #4
profix898 commented@dmitrig01: Because you think it's confusing, it doesnt mean that the 'code needs work'. Its just your opinion. Or is there stg wrong with the patch?
Comment #5
profix898 commented@dmitrig01: Because you think it's confusing, it doesnt mean that the 'code needs work'. Its just your opinion. Or is there stg wrong with the patch?
Comment #6
profix898 commentedStill applies (with 4 lines offset). Anyone?
Comment #7
dries commentedCommitted to CVS HEAD. Thanks.
Comment #8
(not verified) commented