Can't store ip2long in database -- and preg_replace is slow anyways

Care to provide a bit more background/context? How does this relate to ip2long?

Ah, right! :-)

no longer applies.

The patch creates multiple issues with the menu system -- causing all pages to return NOT FOUND. Trying to decipher exactly what.

Screenshot is of testsite home page after applying the patch. Using HEAD and pgSQL 8.2.3.

Initial finding: db_query_load_values() fails to return a value, but I still have odd behavior. Investigating.

Changes line 474.

#  $query = preg_replace_callback(DB_QUERY_REGEXP, '_db_query_callback', $query);
  return preg_replace_callback(DB_QUERY_REGEXP, '_db_query_callback', $query);

Um... db_query_load_values is not returning $query.

For reference, here's the similar function from database-mysql-common.inc:

function db_query_load_values($query, $args) {
  $args = array_map('db_escape_string', $args);
  array_unshift($args, str_replace('%b', "'%s'", $query));
  return call_user_func_array('sprintf', $args);
}

Fixing the return value for db_query_load_values allows this statement to work correctly.

db_query('INSERT INTO {test} (foo) VALUES (%u)', ip2long('255.255.255.255'));

Where {test} is defined as:

foo 	bigint 	

pgSQL 8.2.3

Changes in database_pgsql.inc:

function db_query_load_values($query, $args) {
  _db_query_callback($args, TRUE);
  return preg_replace_callback(DB_QUERY_REGEXP, '_db_query_callback', $query);
}

Patch and an additional comment because I had to scratch my head for a second to figure out what was going on.

Patch works as desired; %u syntax functions correctly in pgSQL. RTBC.

Being an API change, I hand this over to Dries for consideration.

This issue combines two things: it adds support for longs _and_ it rewrite part of the database API for performance's sake. This should be split in two issues.

Does this issue exist in current D6?