if the fieldset contains an EM - all between <em></em> is not displayed.

<fieldset class=" collapsible collapsed"><legend>Modules in <em>modules</em></legend>
CommentFileSizeAuthor
#5 fieldset_html_in_title.patch626 bytesedmund.kwok
#1 Fieldset title display bug #140253.png10.74 KBedmund.kwok

Comments

edmund.kwok’s picture

edmund.kwok commented
Title: fieldset legend incomplete » Fieldset title does not include text enclosed in tags when collapsed
Component: Garland theme » system.module
StatusFileSize
new Fieldset title display bug #140253.png10.74 KB

Managed to replicate this bug in 5.1 and with a contributed theme (glossyblue), tested on Firefox 2, Mac. When the fieldset is expanded, the title is displayed as usual, but when collapsed, text enclosed in tags (e.g. em, strong) are hidden. Changed title to reflect the issue better. See the attached screenshot for an example.

I traced it to a css declaration in the system.css file around line 309:

html.js fieldset.collapsed * {
  display: none;
}

Removing that seems to fix the problem and I don't see other repercussions. But I am no expert in css and not sure if it serves another purpose. Comments from css experts?

Steven’s picture

Steven commented

Removing that line will cause fieldsets to snap shut after the DOM completes loading. This wouldn't be noticable if you're only testing locally. Better patch needed.

ricabrantes’s picture

ricabrantes commented

Any news???

beginner’s picture

beginner commented
Version: 5.1 » 7.x-dev

The bug is still present.
It was also reported here:
http://drupal.org/node/251292
I had to change the form definition from:

  $form[$role] = array(
    '#type' => 'fieldset',
    '#collapsible' => true,
    '#collapsed' => true,
    '#title' => t('Front Page for %rolename.', array('%rolename' => $rolename)),
  );

to 

  $form[$role] = array(
    '#type' => 'fieldset',
    '#collapsible' => true,
    '#collapsed' => true,
    '#title' => t('Front Page for !rolename.', array('!rolename' => $rolename)), // % becomes !
  );
edmund.kwok’s picture

edmund.kwok commented
Status: Active » Needs review
StatusFileSize
new fieldset_html_in_title.patch626 bytes

Attached patch seems to fix this issue in Safari 3.1 (Mac), Firefox 2.0.0.8 (Mac) and IE6 (Mac). Need more testing to verify though; not sure if there are any side effects.

Dublin Drupaller’s picture

Dublin Drupaller commented
Assigned: Unassigned » Dublin Drupaller

thanks for the patch edkwh...I'll test it later. Looks good.

Dub

Dublin Drupaller’s picture

Dublin Drupaller commented
Assigned: Dublin Drupaller » Unassigned

oops. wrong module. I don't have permissions to commit to the system.module. changing assigned to status

hass’s picture

hass commented

As i remember from a Garland bug regarding this issue the above patch have side effects... try to search for a "garland legend" issue...

cburschka’s picture

cburschka
they
commented

As a warning, * affects tags that would not normally be displayed - not that the legend is likely to contain a script or a style tag, of course.

Status: Needs review » Needs work

The last submitted patch failed testing.

lilou’s picture

lilou commented
Status: Needs work » Needs review

See: #335122: Test clean HEAD after every commit and http://pastebin.ca/1258476

Status: Needs review » Needs work

The last submitted patch failed testing.

casey’s picture

casey commented
Version: 7.x-dev » 6.x-dev

Fixed in D7: #676800: Fieldsets break design badly

MA-Hugh’s picture

MA-Hugh commented

The bug definitely arises due the wildcard, either the core needs to filter out tags for collapsible titles or add something to allow certain formatting inside them.

I have tried several global fixes on my system, has anyone fully got this fixed?

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.