Problem/Motivation
This stems from the following issue: #1334830: Missing comment date
The feeds_comment_processor module uses the comment_save function from the drupal api comment.module. There are cases in which the $comment->hostname is passed into the comment_save function, but currently the hostname on a new comment is always reset to the ip_address().
Proposed resolution
Similar to the other comment fields, the $comment->hostname should be checked if it is set before setting a default with ip_address(). I will attach a proposed patch.
API changes
comment_save will not overwrite the hostname value if it is already set.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | CommentSaveKeepHostname-1380626-4.patch | 901 bytes | dooug |
| #1 | CommentSaveKeepHostname-1380626-1.patch | 525 bytes | dooug |
Comments
Comment #1
dooug commentedComment #2
dooug commented#1: CommentSaveKeepHostname-1380626-1.patch queued for re-testing.
Comment #3
dooug commented#1: CommentSaveKeepHostname-1380626-1.patch queued for re-testing.
Comment #4
dooug commentedre-rolled to the latest dev. It is a very simple patch, it was somewhat confirmed here: http://drupal.org/node/1334830#comment-6934778. Please review!
Comment #5
dooug commented