Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
statistics.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Oct 2011 at 19:48 UTC
Updated:
29 Jul 2014 at 20:05 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
iamEAP commentedSince removing accesslog (and a number of intermediary, unrelated improvements to the Statistics test suite), I think the qualms raised in the original issue are largely taken care of.
That being said, I think the test coverage is lacking in some places and redundant in others in regards to logging. Specifically:
Comment #2
iamEAP commentedAnd upon further reflection, checking for the existence of the scripts/settings across cache/uncached/authenticated is a little absurd too.
We just need to ensure that:
Patch attached.
Comment #3
iamEAP commented#2: drupal-statistics_refactor_log_tests-1326698-2.patch queued for re-testing.
Comment #4
iamEAP commentedAlso re-categorizing as a bug and renaming, since tests as they exist now are not fully covering the behavior of the module.
Comment #5
iamEAP commented#2: drupal-statistics_refactor_log_tests-1326698-2.patch queued for re-testing.
Comment #7
iamEAP commentedRe-roll of #2.
Comment #7.0
iamEAP commentedMinor fixes for readability in English.
Comment #8
iamEAP commentedAaaand Statistics broke because these tests weren't in. All of these test improvements ended up going in via #2172859: Statistics JS and settings are not included on node pages, which fixed the module too.
Closing as a dupe, now.