The local variable $num_args may not have been initialized and method "condition" has only 3 parameters
file : /includes/database/select.inc line 640

CommentFileSizeAuthor
#4 remove-bogus-condition-arg-1297992-4.patch1.02 KBpillarsdotnet

Comments

marcingy’s picture

marcingy commented
Status: Active » Postponed (maintainer needs more info)

How do you recreate this bug thanks?

LG666’s picture

LG666 commented

file : /includes/database/select.inc Line 621

  public function havingCondition($field, $value = NULL, $operator = '=') {
    $this->query->condition($field, $value, $operator, $num_args);
    return $this;
  }

must be changed by 

  public function havingCondition($field, $value = NULL, $operator = '=') {
    $this->query->condition($field, $value, $operator);
    return $this;
  }

Drupal 7.8 running on PHP with error_reporting = E_ALL | E_STRICT generates a lot of logs

damien tournoud’s picture

damien tournoud commented
Version: 7.8 » 8.x-dev
Status: Postponed (maintainer needs more info) » Active

The query extender. Always so lovely.

pillarsdotnet’s picture

pillarsdotnet commented
Title: incorrect number of parameters on call of "condition" method » Remove bogus $num_args parameter in call to SelectQuery::condition() from SelectQueryInterface::havingCondition().
Status: Active » Needs review
StatusFileSize
new remove-bogus-condition-arg-1297992-4.patch1.02 KB

Patch.

pillarsdotnet’s picture

pillarsdotnet commented
Issue tags: +Needs backport to D7

Tagging for backport.

mac_weber’s picture

mac_weber commented
Status: Needs review » Reviewed & tested by the community
chx’s picture

chx commented
Status: Reviewed & tested by the community » Closed (duplicate)

Sigh. This does not even have tests and there's a lot more bugs re having, I will find the revelant issue and edit this message.Edit: #1258000: SelectQuery::countQuery() inappropriately removes SQL expressions