It seems to be mostly a cleanup script relating to CVS usage. Also: what the hell is DEADJOE?

CommentFileSizeAuthor
#2 remove_codeclear-1282524-1.patch743 bytesskottler

Comments

tr’s picture

tr commented

This is not mainly CVS usage. clean-code.sh has some utility in removing files that are a normal side-effect of development. *.rej and *.orig are still generated as part of the patch process under Git, for example.

However, I do agree that it is highly questionable whether this should be in core. Perhaps we should have a developer tools module for this stuff. Oh wait, that's drush ... Why not just turn this into a drush script? I'd be willing to do the work if there's agreement that this should be removed from core.

From http://www.juniper.net/security/auto/vulnerabilities/vuln1959.html :

joe is a text editor by Joseph Allen, which features familar functions to users of both Microsoft text editors and vi users. A problem occurs with the editor when a session abnormally exits.

Upon abnormal exit, the text editor saves any changes made to the file being edited into a new file in the current working directory labeled DEADJOE.

I have no idea why we should be cleaning up after the joe editor in core. Why not also remove .swp files from vi, etc.?

skottler’s picture

skottler commented
Status: Active » Needs review
StatusFileSize
new remove_codeclear-1282524-1.patch743 bytes

I agree that this script is outdated. Here is a patch to remove it completely.

pillarsdotnet’s picture

pillarsdotnet commented
Status: Needs review » Reviewed & tested by the community

+1

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jpklein’s picture

jpklein commented

FYI: "DEADJOE" files are created when a session with the *nix text-editor joe is terminated with unsaved changes. :)