Hello,

I'm working on a SQLite layer for Drupal as a hobby. It's very functional, but I have the following problem: your module uses some queries with COUNT(DISTINCT(...)). I'm not sure is this syntax is SQL standard, but it can by rewritten using a GROUP BY clause (in a 100% standard way). For instance:
in line 170: "SELECT COUNT(DISTINCT(message)) FROM {watchdog} WHERE type = '%s'" could be replaced with "SELECT COUNT(*) FROM {watchdog} WHERE type = '%s'" GROUP BY message';

You may notice that the queries I'm suggesting are shorter, cleaner (you may cleary see that you are counting all the lines) and maybe faster (because of possible GROUP BY optimizations).

Best wishes,
Andrei.

CommentFileSizeAuthor
#1 watchdog_7.patch1004 bytesabautu

Comments

abautu’s picture

abautu commented
Assigned: Unassigned » abautu
Status: Active » Reviewed & tested by the community
StatusFileSize
new watchdog_7.patch1004 bytes

I learned how to use a CVS, how Drupal CVS works, how patches are made and I thought to give it a try. I've tested the patch on my installation.

Crell’s picture

Crell commented
Status: Reviewed & tested by the community » Closed (duplicate)

1) Do not post duplicate issues to different issue queues.
2) Do not set your own patch to "ready to be committed".
3) New features go against 6.x, not against the stable version.
4) Do check the issue queue before posting, as there is already an effort for SQLite support: http://drupal.org/node/67349

Thank you.