Closed (fixed)
Project:
Drupal core
Version:
4.6.0
Component:
postgresql database
Priority:
Critical
Category:
Task
Assigned:
Reporter:
Created:
7 Sep 2004 at 14:11 UTC
Updated:
4 Jan 2006 at 00:30 UTC
Jump to comment: Most recent file
This patch brings the postgres port up to synch with CVS , aswell as fixes the following bugs
1) Get rid of PEAR. this patch contains a new database.pgsql.inc file, which makes database.pear.inc obsolete , aswell as make thousands less lines of code that has to be loaded.
2) User role addition fails.
All of the new functionality I have tested , and confirmed to work (profiles, filters , templates and locales).
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | postgres080904b.tar.bz2 | 8.73 KB | adrian |
| #4 | postgres_patch.tar_2.bz2 | 8.02 KB | adrian |
| #1 | postgres_patch.tar_0.bz2 | 6.8 KB | adrian |
| postgres_patch.tar.bz2 | 6.44 KB | adrian |
Comments
Comment #1
adrian commentedHere is an updated patch, which fixes some more problems i found in testing, but more importantly .. fixes Cache problem with Postgres by introducing new db_encode_blob and db_decode_blob functions.
This patch also includes the relevant functions for database.mysql.inc and the patch for bootstrap.inc
Comment #2
dries commentedJust a small note: getting rid of PEAR and introducing new database abstraction function is somewhat intrusive at this point and could do with being tested by others. Thumb up this patch if it works for you.
Comment #3
adrian commentedRolled in some more verified patches.
1) Menu problems with Postgres (this is a highly critical 1 line fix)
2) Archive module fails with Postgres
3) Postgres setup problems - changes to database.pgsql (although i made these changes myself before finding this patch)
4) Book module fails with Postgres
5) Postgres problems following creation of a new type of user - which is actually about a taxonomy.module bug.
6) Creating accregator_item_table in PostgreSQL
Most of these patches are marked as release critical.
Like dries said, this patch needs some testing from postgres users, also .. can anyone tell me if Postgres problem in user.module and SELECT statements broken if using Postgresql are still valid?
Comment #4
adrian commentedand here is the actual patch
Comment #5
adrian commentedI missed something with the filter update and database.pgsql , but it's fixed now.
Also found two other patches that were rolled in.
1) Postgres - Polls not displayed on Poll Page
2) Blog module has sql errors with postgres
Thanks to alan chandler for most of these patches.
Comment #6
dries commentedCommitted to HEAD. Continue testing the PostgreSQL backend please.
Comment #7
AlanChandler commentedI am trying to test this, but I can't even get started.
All I get is
Warning: pg_connect(): Cannot create new link. Too many open links (0) in /usr/share/drupal/includes/database.pgsql.inc on line 28
Warning: pg_last_error(): No PostgreSQL link opened yet in /usr/share/drupal/includes/database.pgsql.inc on line 28
I assume this is something simple - but I don't know what
Comment #8
AlanChandler commentedI mistakenly added an extension=pgsql.so to my php.ini. This appears to be a no no.
Comment #9
(not verified) commentedUsing from HEAD as of this morning and everything appears to work fine. :)
Comment #10
(not verified) commentedComment #11
JoeWalker commentedI was just about to give up with Drupal's postgres support and go through some extreme pain in moving my data to mysql. Maybe this could help me out.
Will the patch work against 4.6.2/3?
Given that my site is live working, but only hobbling along would you recommend that I had a go with this? Is having a go with this likely to make an upgrade to 4.7 harder? Would I be better off just going straight to HEAD?
Comment #12
Cvbge commentedThis patch probably won't work.
Please use CVS ("HEAD") version, or one of 4.7 betas.