I just upgraded Drupal 4.7 to 5.0-rc1 and ran into a lot of trouble with JavaScript in update.php and other places not working properly. Turns out it was the (Firefox 2) browser cache at fault - the browser cache seems to have used some old version of Drupal JavaScript components, resulting in all sorts of errors like 'Drupal not defined' and the like. After clearing the browser cache, the problem vanished.

I'm not quite sure what to make of this problem. I'd suggest to add a 'Clear browser cache' instruction as step 5 in UPGRADE.txt, but since you also have to be logged in as user ID 1, you'd have to be careful to not clear the cookies as well. It also does not solve the problem for other visitors to the page.

CommentFileSizeAuthor
#12 106195-addcomma.patch3.11 KBjhodgdon
#11 upgrade_instructions-106195-rerolled.patch2.65 KBAnonymous (not verified)
#9 upgrade_instructions-106195-corrected.patch2.82 KBAnonymous (not verified)
#4 upgrade_instructions-106195.patch3.37 KBAnonymous (not verified)

Comments

brianV’s picture

brianV commented
Component: javascript » documentation

Marking as a documentation bug.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 5.0-rc1 » 7.x-dev

Probably the same issue would exist in Drupal 7 -- bumping up for decision on whether we need to document this in UPGRADE.txt files.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: browser cache breaks Drupal 5.0 upgrade » UPDATE.txt should mention clearing browser cache

Changing title to reflect what needs to be done (maybe).

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Needs review
StatusFileSize
new upgrade_instructions-106195.patch3.37 KB

Added it at step 5 as suggested.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

Looks fine to me. I'd like a second opinion though.

grendzy’s picture

grendzy commented
Status: Needs review » Needs work

I would suggest the clear cache step should be added between 9 & 10. As the patch is written, users are instructed to disable custom and contrib modules after clearing the browser cache, which will refill the cache as soon as the user visits /admin/build/modules right?

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented

And this text

For a major update, such as from 5.x to 6.x,..

should be

For a major update, such as from 6.x to 7.x,..
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new upgrade_instructions-106195-corrected.patch2.82 KB

Made changes according to grendzys suggestion as it seems very reasonable. Also changed for: "6.x to 7.x".

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented 
+++ UPGRADE.txt	22 Mar 2010 07:30:33 -0000
@@ -60,9 +60,11 @@ Let's begin!
+10.  Verify the new configuration file to make sure it has correct information.

One space too many between 10. and Verify.

Also, the current patch no longer applies cleanly to HEAD, so needs a reroll.

Powered by Dreditor.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review
StatusFileSize
new upgrade_instructions-106195-rerolled.patch2.65 KB

Rerolled and errors corrected! :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new 106195-addcomma.patch3.11 KB

I like it. I added a comma and changed a reference to step #10 above to now point to step 11. Taking the liberty of marking as RTBC...

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.