Problem/Motivation

Gulp JS minifier adds "use strict" by default, what triggers a Drupal Core bug.

Steps to reproduce

Proposed resolution

Remove the Javascript uglifier from the gulpfile and the packet.json.
Let Drupal minify the JS files.

Probably solve this issue here too afterwards (seperate issue branch!): https://www.drupal.org/project/drowl_paragraphs/issues/3346920

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drowl_paragraphs-3346991

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

thomas.frobieter created an issue. See original summary.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Assigned: thomas.frobieter » anybody
Status: Active » Needs review

@anybody please review:
https://git.drupalcode.org/issue/drowl_paragraphs-3346991/-/commit/0a813...

Anybody opened merge request !43

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » Unassigned
Status: Needs review » Fixed

Merged! Well done @thomas.frobieter

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

Also fixed in the other DROWL modules (no seperate issues - commit messages mention this issue here)

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

Turns out.. Gulp minify/uglify wasn't the problem here. Its simply Babels @babel/env preset, that adds the strict mode (see: https://stackoverflow.com/questions/33821312/how-to-remove-global-use-st...).

We dont care anymore about ES6 support, so I'll remove this.

However, we leave the JS files unminified and let Drupal do the job, even if its unrelated to the origin issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.