Problem/Motivation

Set up default gitlab, tugboat, basic test etc.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drowl_canvas-3614608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Title: Set up default gitlab, tugboat, basic test etc. » Set up composer.json, default gitlab, tugboat, basic test etc.
Version: » 1.x-dev

grevil made their first commit to this issue’s fork.

grevil opened merge request !1

grevil’s picture

grevil commented
Title: Set up composer.json, default gitlab, tugboat, basic test etc. » Set up composer.json, default gitlab, tugboat, basic test, rewrite README etc.
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

Alright, that should be it. Let's see if the tests succeed!

grevil’s picture

grevil commented
Assigned: Unassigned » thomas.frobieter
Status: Needs review » Needs work

Ah very nice, the tests fail because of the new construct parameter introduced in canvas. @thomas.frobieter is there already an issue for this on canvas_builder's site? Or how should we proceed here (we could specifiy a concrete "canvas" version in our composer.json, but that should be done on canvas_builder's site)?

Please also review the README.

Afterward, @anybody can have a brief glance at the changes.

FYI: PHPStan fails, because the drupal ci script is broken right now (receives a 500 server error), running phpstan locally shows no errors. Should be working soon again.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: thomas.frobieter » grevil

Tugboat fails for the same reason. Reviewing now, depite that.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks @grevil LGTM! Can be merged once all comments are resolved and tests are green.

Maybe just use * as version dependency for canvas_builder for now? I'll try that... We can switch to stable once ready.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » thomas.frobieter

Okay that does not help... but at least *allows* using the dev version. So maybe we should keep the * as long as we don't have to be more specific.

I've asked for a new release at canvas_builder: #3613873: ArgumentCountError: Too few arguments to function Drupal\canvas\AutoSave\AutoSaveManager::__construct() after updating to Canvas 1.9.0

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: thomas.frobieter » Unassigned

  • anybody committed 87d8cb5d on 1.x authored by grevil 
    task: #3614608 Set up composer.json, default gitlab, tugboat, basic test...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.