Problem/Motivation

Find out why the node add buttons don't appear any more. In the page manager version they were working. Alternatively we could provide them as twig variable programatically.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork drowl_admin_dashboard-3571297

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

Its currently broken on vl and next, so I am unable to test this.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@thomas.frobieter test at ZZP

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Active » Fixed

It works when I remove the parent parameter: parent: 'admin:admin_toolbar_tools.extra_links:node.add',

So something is wrong with this.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Fixed » Needs work

Okay, parent: 'content:navigation.create' seemed right, but it is not.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented

mhm, okay this really is the new "add content" menu of the new Drupal navigation.

thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Assigned: thomas.frobieter » anybody
thomas.frobieter’s picture

thomas.frobieter
Primary language German
Location EU
commented
Status: Needs work » Fixed

Okay its correct. Its just a bit confusing that it now holds "user" and "image", not only node creation links.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: anybody » thomas.frobieter
Status: Fixed » Needs work

@thomas.frobieter just saw that the block is broken on existing pages, e.g. DRC:
/admin/dashboard

Any idea how to fix it on the projects or in code here?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: thomas.frobieter » Unassigned

@thomas.frobieter: Okay I found the reason. We need another version IMHO.

  • 3.x should be compatible with old projects using admin_toolbar etc.
  • 4.x should be compatible with the new navigation

I'll create a 4.x branch from the current implementation and then fix 3.x for the many existing projects using it.

Some of the items need to use routes from admin_toolbar_tools, e.g. the "add" buttons.

anybody opened merge request !17

  • anybody committed 2aef7cf6 on 3.x 
    Resolve #3571297 "Fix 3.x admin navigation based"