droptor_check_domain() always fails on websites which are running behind a reverse proxy, as $_SERVER['REMOTE_ADDR'] is the IP of the proxy, not the IP of the real client.

It seems like Drupal core already has a function ip_address() which looks for the X-Forwarded-For HTTP header if the site is known to run behind a reverse proxy.

Comments

cyberwolf’s picture

cyberwolf commented
Version: 7.x-3.x-dev » 7.x-2.71

Sorry for initially reporting the wrong version number.
I see in git now this was fixed in January already (commit 03280a50a22f0785e26f60b4d918e7ce9e2fb820). Any chance to get this in the 2.x branch as well? Or should I go for 3.x-dev?

jemond’s picture

jemond commented

Hey Cyberwolf. You should go right to 3.0, it should be stable.

cyberwolf’s picture

cyberwolf commented

But there is no stable release out yet for the 3.x branch? I only see 3.x-dev.

jemond’s picture

jemond commented

Hey Cyberwolf,

I will be releasing 3.0 very soon. It will have this fix.

Cheers,
jpe

jemond’s picture

jemond commented
Status: Active » Postponed
zilverdistel’s picture

zilverdistel commented

subscribing

jemond’s picture

jemond commented
Status: Postponed » Closed (fixed)

This is fixed! The release will appear when the d.o crawler does the update... 7.x-2.8