droptor_memory

column id - difference on: length
declared: array('description' => 'TODO: please describe this field!', 'type' => 'serial', 'length' => 15, 'not null' => TRUE)
actual: array('description' => 'TODO: please describe this field!', 'type' => 'serial', 'not null' => TRUE)
column dt - difference on: length
declared: array('description' => 'TODO: please describe this field!', 'type' => 'int', 'length' => 11, 'not null' => TRUE)
actual: array('description' => 'TODO: please describe this field!', 'type' => 'int', 'not null' => TRUE)
column memory - difference on: length
declared: array('description' => 'TODO: please describe this field!', 'type' => 'int', 'length' => 15, 'not null' => TRUE)
actual: array('description' => 'TODO: please describe this field!', 'type' => 'int', 'not null' => TRUE)
column execution_time - difference on: length
declared: array('description' => 'TODO: please describe this field!', 'type' => 'int', 'length' => 11, 'not null' => TRUE)
actual: array('description' => 'TODO: please describe this field!', 'type' => 'int', 'not null' => TRUE)

CommentFileSizeAuthor
#9 droptor.install.zip1009 byteswim leers
#4 droptor-1150148-4.patch2.47 KBwim leers

Comments

jemond’s picture

jemond commented
Assigned: Unassigned » jemond

Will take a look.

Starminder’s picture

Starminder commented

Thanks - not the end of the world, but it's nice when it matches :)

basicmagic.net’s picture

basicmagic.net commented

subscribe

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Schema Mismatch » Schema mismatch (minor errors in DB schema)
Assigned: jemond » wim leers
Status: Active » Needs review
StatusFileSize
new droptor-1150148-4.patch2.47 KB

Yep, confirmed. Basically, you're setting the length property where it doesn't exist: for columns of the type 'serial' and 'int'. That's all :)

Patch attached that fixes this. It also makes the .install file comply with Drupal coding guidelines (proper doxygen usage, proper indentation, etc.).

jemond’s picture

jemond commented

@Wim - Awesome, I will take a look and update you later this week.

jpe

jemond’s picture

jemond commented

Hey Wim,

Sorry for my delay in responding. This looks great and it's ready to add. But I'm getting an odd Git error:

"fatal: git diff header lacks filename information when removing 1 leading pathna me components (line 5)"

I think it has to do with line breaks. Did you create this on Windows, Mac, or Linux?

jpe

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

OS X. But the funny thing is that line 5 doesn't contain pathnames… You should be able to apply it with the patch command as well. (patch -p0 < patchfile)

jemond’s picture

jemond commented

Hmm, that didn't seem to work either.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
StatusFileSize
new droptor.install.zip1009 bytes

Here's the modified .install file, then.

jemond’s picture

jemond commented
Status: Needs review » Closed (fixed)

Hey Wim,

Thanks for this! Nice work. Committed and attributed to you.

Cheers,
jpe