Viewing 'Your Posts' (your_posts.feature)

Please let me know if someone is working on this issue.

Thank you

No one is actively working on this. We took a trial run at writing features at our user group meetup, and this is one of those issues. Please feel free to start working on it.

I will start working on this.

Tagging to sprint 3

As we are not able to login with any user in the git6site ,I have written the feature by taking reference of drupal.org with logged in user as "ksbalajisundar" and taken the posts based on this user.

Once the git6site issue: #1720134: Script the re-creation of all needed test user accounts and passwords for git6site is fixed, I will change the "logged in user" with git user and take the posts of the changed user and modify in the feature and update the patch accordingly.

Attaching the patch file.

Please review the Given/When/Then structures in the .feature file
http://drupal.org/node/1578324#important

I have modified the structures in the .feature file as per standards.

Attaching the updated patch file.

I'm getting the following PHP Fatal error after applying and running:

    And I should see the following <texts>                 # FeatureContext::iShouldSeeTheFollowingTexts()
      | texts        |
      | Type         |
      | Posts        |
      | Author       |
      | Replies      |
      | Last updated |
PHP Fatal error:  Call to a member function find() on a non-object in /home/melissa/doobie/features/bootstrap/FeatureContext.php on line 1943

tagging as sprint 4

Made corrections and uploaded the patch.

Please review it.

While you're making changes, would you tab out the table endings for readability?

+++ b/features/drupalorg/your_posts.feature
@@ -0,0 +1,63 @@
+Feature: Logged-in user views list of own posts

We need the full Feature statement:

In order to keep track of responses to issues I've posted
As an authenticated user
I want to find them listed all in a single place

+++ b/features/drupalorg/your_posts.feature
@@ -0,0 +1,63 @@
+    And I should see the following <texts>

This is your Then statement (and this is one of those weird ones that has no When in the scenario; that seems right in this case)

+++ b/features/drupalorg/your_posts.feature
@@ -0,0 +1,63 @@
+    Then I should see at least "5" replies for the post

This should be And, not then, because of the adjustment above.

+++ b/features/drupalorg/your_posts.feature
@@ -0,0 +1,63 @@
+  Scenario: Verify pagination links: First page
+    And I should see the following <links>
+    | links |
+    | next |
+    | last |
+    | 1 |
+    | 2 |
+    And I should not see the link "first"

This scenario should begin with a Then statement and all of the first page pagination scenarios should probably precede the scenarios that follow posts.

Made necessary changes as below.
Commit log:75dfa57
Once confirmed will roll out a patch.

One small style correction remains:

Feature: In order to keep track of responses to issues I've posted
As an authenticated user
I want to find them listed all in a single place

should be more like:

Feature:  Your posts
  In order to keep track of responses to issues I've posted
  As an authenticated user
  I want to find them listed all in a single place

Some larger content questions:
Site user will be recreated every time a new database is pulled. All the data for site user will be blank. We need an effective strategy to:

a) delete any posts for the site user if they exist
b) create the data necessary to execute the test

This is something we need to be looking at for all tests: will this pass on both a new copy of the database and one that's been around a while?

Additionally, the step definitions in the patch are missing from this commit, so the tests can't really be executed. Note that I just did a clean up of step language to account for both singular and plural ... any time that you're counting 'at least X' the step should account for the variation.

For example,
@Given /^I should see at least \'(\d+)" new replies for the post$/
would read
@Given /^I should see at least \'(\d+)" new (?:reply|replies) for the post$/

The ?: allows you to group this without creating a backreference (which means it won't be awkwardly bolded in the test output).

With more regular plurals, you may see something more like post(?:|s) which allows either nothing or an s on the end of post.

Also, this particular definition has a mismatched quotes: \'(\d+)" should be "(\d+)"

See #1742962: [meta] Create data for tests re: creating test data.

Made the above suggested changes as per comment no:15 .

please check the commit logs :eb20637
AND 532d9fa,3d6d843

Tagging

I'm not comfortable with defining the post title in the yml file; I'm advancing this to jhedstrom for code review because we really need to contend with this issue. The rest of the feature file looks good.

I agree with #19, if the post title is static enough to go into the yml file, can't we have it be a variable in the feature context? Alternatively, couldn't we grab a post title from the top of a list of posts and save that title in the class variable? If not, let's discuss potential ways around this--the getPostTitleObject() method is confusing to me at this point.

Unless we create data on behalf of 'site user' each time the site is set up or as part of the given statement, this test will fail because we can't guarantee there will be any posts at all when this test runs.

Unless we create data on behalf of 'site user' each time the site is set up or as part of the given statement

I'm inclined towards doing this as a 'given' for now, until we have an easier way for people to run d.o. locally and have full bootstrap capabilities.

tagging

As more steps are required to create test data, adding them in Given will make it bulky, I think. So I have Added a separate scenario to achieve it.

Uploading to the dev branch.
Please check the commit log: a8dae2e

Please review it.

Looks good.

This was merged to master.

Please follow up #1846698: Update user_your_posts.feature for further developments.