Problem/Motivation

PHPUnit tests for Drupal next major are failing due to a missing return type:

PHP Fatal error:  Declaration of Drupal\Tests\domain\Functional\DomainTestBase::drupalUserIsLoggedIn(Drupal\Core\Session\AccountInterface $account) must be compatible with Drupal\Tests\BrowserTestBase::drupalUserIsLoggedIn(Drupal\Core\Session\AccountInterface $account): bool in /builds/issue/domain-3479098/domain/tests/src/Functional/DomainTestBase.php on line 203

See for example https://git.drupalcode.org/issue/domain-3479098/-/jobs/2975840

Proposed resolution

Add function return type for DomainTestBase::drupalUserIsLoggedIn

Issue fork domain-3479102

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !118

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request adds a function return type for DomainTestBase::drupalUserIsLoggedIn and fixes the PHPUnit tests for the next major Drupal version

webflo’s picture

webflo commented
Status: Needs review » Closed (duplicate)

Fixed with https://git.drupalcode.org/project/domain/-/merge_requests/116