Closed (fixed)
Project:
Docvert
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
8 Jul 2011 at 00:51 UTC
Updated:
26 Jul 2011 at 21:21 UTC
Dman, can you please review the code to see that its appropriate to promote this to a full project. On your review I'll promote it to a full project.
Cheers,
Josh
Comments
Comment #1
dman commentedI'm really happy with the architecture I've reviewed on it last night.
A bunch of Drupal style issues have been introduced (recently?) but that's trivial.
I've got patches ready for that already.
Also, the object throws a number of exceptions that the Drupal side doesn't catch properly, I have patches for those of those that I've encountered also.
The code can work as promised, and is going to be a valuable module.
I DO have to look at it with an eye to security (have not focussed on that yet) but I have no great concerns about that.
I'll do a fresh once-over it today, pulling from d.o git now ...
.dan.
Comment #2
coderintherye commentedVery happy to see this, as I had looked into creating a docvert module about 2 years ago, but the project itself was in a little disarray at the time, have been wondering since the conversion to Python how this might work. Will definitely help you guys review, not sure if I'll get anytime for patches though. Keep up the good work.
Comment #3
dman commentedThis weekend:
+ Full coder.module style and layout review. All whitespace and boring stuff like that, no significant code changes
+ Minor additions to help text, form field descriptions, API docblocks
+ Some form validation additions to help test the target docvert server is valid
+ Huge amount of help and install instructions, now in the /help folder for use with advanced_help
Overview
Setting up the server, and troubleshooting notes I made
And for fun:
How to set up a stand-alone EC2 virtual web appliance to do docvert for you
I didn't find any security or general code issues worth worrying about in my per-line review of the code (though I didn't test everything either).
I'll let the dust settle on this, then maybe we can talk about some adjustments to the process I see as being helpful - specifically making the documents get processed on request (and batch API) rather than on every save.
Shall we promote?
Comment #4
dman commentedPromoted to full project at http://drupal.org/project/docvert
... mostly so the new documentations and HOWTOs I'm writing can refer to a good URL.
Also because .. it's working for me now, and I'm actively getting this going.
Comment #5
dman commentedNote, this MAY put anyones git repo out of date - according to the notification I got anyhoo.
You are all best to get a fresh checkout from the info on the project page it seems...
Comment #6
coderintherye commentedDid you go ahead and create a development snapshot/release? If not that would be great, if so then I'll just look for it to show up.
Comment #7
dman commentedNot yet. There's still a few things I want to pack into it.
I've found a difference in the API between docvert server versions 4 and 5, so I want to work around that.
And I have a Feature that can be deployed as a usage example and test case, I'll get that tidied up and then bundle release v.1.0