Closed (fixed)
Project:
Disqus
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Sep 2013 at 09:38 UTC
Updated:
13 Aug 2014 at 10:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
thehong commentedhttps://github.com/andytruong/disqus
Comment #2
thehong commentedComment #3
robloachThis is excellent, thanks so much for pushing forwards on this. Is there anything missing on the github project that I could help push forwards? Would love to get this in.
Comment #4
slashrsm commentedGreat job! I'm really looking forward to this!
Are you already working on a D8 site or do you only work on this for fun?
Comment #4.0
slashrsm commentedNotes tasks.
Comment #4.1
thehong commentedUpdated issue summary.
Comment #4.2
thehong commentedUpdated issue summary.
Comment #5
thehong commentedI will back on this weekend.
Comment #6
thehong commentedComment #7
slashrsm commentedThank you. Your work is great!
I'm not sure if adding values to node object on node_load() is the way to go in Drupal 8. I'd say that something similar to what core comments have done is probably the way to go (#2068331: Convert comment SQL queries to the Entity Query API). I guess that you took similar approach with your patch in #1157912: Entity support, which probably means that we are almost half way there.
I see few advantages with this approach:
1. Disqus comments will be automatically supported on all entity types,
2. Disqus comments will behave similar as core comments, which will make them easier to understand and use,
3. We can probably make this module storage independent if we go that way. We are trying to achieve this with almost everything in core, so it would definitely make sense (see: #2068325: [META] Convert entity SQL queries to the Entity Query API).
How should we tackle this? Should we first try to finish #1157912: Entity support and proceed with Drupal 8 port once we get that in?
Comment #7.0
slashrsm commentedUpdated issue summary.
Comment #8
thamasAny progress on this? I plan to start a very simple D8 site soon and it would be great to use the Disqus service with the supporter module!
Comment #9
deggertsen commentedI may also be interested in testing this if it's to that point yet. Does the patch in #6 work?
Comment #10
andypostMaybe it's time to open 8.x branch or another sandbox?
Comment #11
slashrsm commentedWe have a GSoC project that has a goal of porting Disqus to D8.
Comment #12
JayeshSolanki commentedHi , I would be porting the module to Drupal 8.
Here is the link to the project description : https://groups.drupal.org/node/407793#project9
Also the link to my sandbox project : https://drupal.org/sandbox/jayeshsolanki/2253903
I have rerolled the patch on #6, please check if it applies cleanly and also please review :)
Comment #13
thehong commentedThis module should available for Drupal 8.
- Module info file
- Route
- Configuration, vertical tabs
- Use PSR-0 for classes
- Block to plugin system
- Views
Comment #14
andypostThe proper status