This module should available for Drupal 8.

- Module info file
- Route
- Configuration, vertical tabs
- Use PSR-0 for classes
- Block to plugin system
- Views

Comments

thehong’s picture

thehong’s picture

Assigned: Unassigned » thehong
Status: Active » Needs work
StatusFileSize
new49.17 KB
robloach’s picture

This is excellent, thanks so much for pushing forwards on this. Is there anything missing on the github project that I could help push forwards? Would love to get this in.

slashrsm’s picture

Great job! I'm really looking forward to this!

Are you already working on a D8 site or do you only work on this for fun?

slashrsm’s picture

Issue summary: View changes

Notes tasks.

thehong’s picture

Issue summary: View changes

Updated issue summary.

thehong’s picture

Issue summary: View changes

Updated issue summary.

thehong’s picture

Assigned: thehong » Unassigned
StatusFileSize
new78.89 KB

I will back on this weekend.

thehong’s picture

Status: Needs work » Needs review
StatusFileSize
new88.12 KB
slashrsm’s picture

Thank you. Your work is great!

I'm not sure if adding values to node object on node_load() is the way to go in Drupal 8. I'd say that something similar to what core comments have done is probably the way to go (#2068331: Convert comment SQL queries to the Entity Query API). I guess that you took similar approach with your patch in #1157912: Entity support, which probably means that we are almost half way there.

I see few advantages with this approach:
1. Disqus comments will be automatically supported on all entity types,
2. Disqus comments will behave similar as core comments, which will make them easier to understand and use,
3. We can probably make this module storage independent if we go that way. We are trying to achieve this with almost everything in core, so it would definitely make sense (see: #2068325: [META] Convert entity SQL queries to the Entity Query API).

How should we tackle this? Should we first try to finish #1157912: Entity support and proceed with Drupal 8 port once we get that in?

slashrsm’s picture

Issue summary: View changes

Updated issue summary.

thamas’s picture

Any progress on this? I plan to start a very simple D8 site soon and it would be great to use the Disqus service with the supporter module!

deggertsen’s picture

I may also be interested in testing this if it's to that point yet. Does the patch in #6 work?

andypost’s picture

Issue summary: View changes

Maybe it's time to open 8.x branch or another sandbox?

slashrsm’s picture

We have a GSoC project that has a goal of porting Disqus to D8.

JayeshSolanki’s picture

StatusFileSize
new94.12 KB

Hi , I would be porting the module to Drupal 8.

Here is the link to the project description : https://groups.drupal.org/node/407793#project9

Also the link to my sandbox project : https://drupal.org/sandbox/jayeshsolanki/2253903

I have rerolled the patch on #6, please check if it applies cleanly and also please review :)

thehong’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Needs review » Closed (won't fix)

This module should available for Drupal 8.

- Module info file
- Route
- Configuration, vertical tabs
- Use PSR-0 for classes
- Block to plugin system
- Views

andypost’s picture

Status: Closed (won't fix) » Fixed

The proper status

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.