Problem/Motivation

When we did #3562060: Render UI with admin theme , it was decided to not hide the "Default Admin" theme toolbar on display builder pages because there was uncertainties about how this toolbar is added and we didn't want to risk side effects by using a loosely defined hook.

I guess it was the good approach at this time, but we have now something kind of useless which is taking as much screen estate as our toolbar:

Proposed resolution

2 weeks after the switch to admin theme, we can try again as an isolated task.

Test with Claro, Gin contrib and the new default admin theme.

Let's keep the "do we need still need the Expand button?" question out of this discussion. It is tempting to ask such question once the Gin toolbar is removed. But it was discussed many times since July and it was confirmed as absolutely needed, even before this Gin toolbar was visible, even if I personally still struggle to understand this.

CommentFileSizeAuthor
estate.png22.05 KBpdureau

Issue fork display_builder-3633034

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pdureau created an issue. See original summary.

pdureau opened merge request !514

pdureau’s picture

pdureau commented
Status: Active » Needs review

MR ready for review: https://git.drupalcode.org/project/display_builder/-/merge_reque

I was not able to just copy what we already got in #3562060: Render UI with admin theme because it triggers a PHPMD NPathComplexity errror.

All tests with Navigation nodule installed.

Using Default Admin theme from Drupal 11.4

  • Default admin toolbar not visible in Display Builder page : ✅
  • Default admin toolbar still visible in /admin/structure/page-layout with the expected breadcrumb and local actions: ✅
  • Navigation toolbar (which is another toolbar) still visible in /user/1 with the expected title and buttons: ✅

Using Claro:

  • Default admin toolbar not visible in Display Builder page : ✅
  • Default admin toolbar not visible in /admin/structure/page-layout with the expected breadcrumb and local actions: ✅
  • Navigation toolbar (which is another toolbar) still visible in /user/1 with the expected title and buttons: ✅

I keep on my side because of a phpunit functional error:

  public function testCurrentDisplayIsExcludedFromItsOwnList(): void {
    ...
    $this->drupalGet(\sprintf('/entity_test/%d/display/full', $entity->id()));
    $this->assertSession()->linkExists('Display: Teaser');
  }

It is weird because this links doesn't exist in those pages, with or without the current change.