Problem/Motivation
Since Builder panel has been renamed "Canvas" panel, I witness confusion to the people I was demoing to:
- In Poland DrupalCamp in September
- In Rotterdam DrupalCon early October
- In French DrupalMeetup mid October
Each time, people publicly and verbally asked what the heck was going one here. In the Meetup, someone even believed i was demoing Canvas module from Acquia.
Canvas brand is too strong in the Drupal world. I am afraid we can't afford to confuse users like that.
Proposed resolution
I will do a proposal bringing "Builder" back, because it allows us to just rename the plugin label and the documentation, the classes and ID still being BuilderPanel, builder and BuilderPanelTest.
But any name proposal is welcomed.
Issue fork display_builder-3631732
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mogtofu33 commentedComment #3
pdureau commentedChanges done locally. Pushed, pipeline running
I didn't know "Canvas" term has muscle in so many parts of the codebase (test names, HTML class names...). I was expecting it to be only in some user facing strings.
The diff may be scary ( 115 files changed, 726 lines changes), but most of the changes happened in comments, not in proper code. And 111 of the changed lines (15% of total) are
displayBuilder.canvasFrame()calls.What have been done
In code, in the order of importance.
User-facing:
Backend code:
Frontend code:
Tests:
What have been kept
Mention of off-canvas mechanism from Core, and mentions of Acquia Canvas in FAQ.
Comment #5
pdureau commentedComment #7
mogtofu33 commentedComment #9
pdureau commentedHas been shipped in beta9
Comment #10
pdureau commented