Problem/Motivation

The Display Builder context menu currently has no close button and no keyboard shortcut (Escape) to dismiss it. The only way to close the menu is to click outside the menu on an element without data-node-id, or to select a menu item.
This is a minor usability issue — users who right-click to open the menu expect either a visible close button (X) in the menu header, or the Escape key to dismiss it.

Steps to reproduce

Proposed resolution

Close button in menu header — Added a header row to the contextual menu that contains the path label on the left and an X (close) icon button on the right.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork display_builder-3613169

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ipumpkin created an issue. See original summary.

ipumpkin opened merge request !320

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Active » Needs review
mogtofu33’s picture

mogtofu33 commented
Status: Needs review » Needs work

Thanks for the feat, the ci needs no error to set an issue 'Need review', warning are ok but not errors, could you please fix linting issue before set in review.

ipumpkin’s picture

ipumpkin
Primary language Chinese, Simplified
Location China
commented
Status: Needs work » Needs review

@mogtofu33 Thank you for your guidance and review. I will pay attention to this issue in the future.

mogtofu33’s picture

mogtofu33 commented
Assigned: Unassigned » mogtofu33

mogtofu33’s picture

mogtofu33 commented
Assigned: mogtofu33 » Unassigned
Status: Needs review » Fixed

Thanks for this feat.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.