The module displays all revisions as authored by Anonymous or Anonymous (not verified) in all views (revisions list and the actual diff view). I believe this because the correct object is not being passed into the theme('username', $array) functions in diff.pages.inc. I think the function is expecting at least an array with an item whose key is account and value is a user object.

I am using Diff 7.x.-2.0-beta2 and Drupal Core 7.0-rc1.

CommentFileSizeAuthor
#12 diff-994204-12.patch2.19 KBdanepowell
#2 diff-994204-2.patch2.06 KBquartsize
#1 diff-994204.patch1.41 KBpmorel

Comments

pmorel’s picture

pmorel commented
StatusFileSize
new diff-994204.patch1.41 KB 
-          '!username' => theme('username', array('name' => $revision))))
+          '!username' => theme('username', array('account' => $revision))))

fixes the problem.

quartsize’s picture

quartsize commented
Status: Active » Needs review
StatusFileSize
new diff-994204-2.patch2.06 KB

This patch extends pmorel's fix in #1 to the diff view as well as the revisions list.

mariusz.slonina’s picture

mariusz.slonina commented

Works on my local box (D7.0, Diff-beta2), thanks :)

amanaplan’s picture

amanaplan commented
Status: Needs review » Reviewed & tested by the community

Works for me too (Diff 7.x.-2.0-beta2 and Drupal Core 7.0). Marking at RTBC.

hansfn’s picture

hansfn commented

Bump. Works for me too.

xenyo’s picture

xenyo commented

Worked Great for me Thx.

ginc’s picture

ginc commented
Status: Reviewed & tested by the community » Patch (to be ported)

seems OK

wagafo’s picture

wagafo commented

I have this issue with Drupal 6, Diff 6.x-2.x-dev (2011-Febrer-25), at the relevant lines it says:

'!username' => theme('username', $revision)

so it seems that this patch cannot be applied to version 6. Any suggestion for drupal 6 and Diff 6?

CandC540’s picture

CandC540 commented

Works on my local install as well.

fonant’s picture

fonant commented

Patch #2 above works fine for me, Drupal 7 and Diff 7.x-2.0-beta2

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Please see #1182154-3: Offering to maintain Diff if you'd be willing to take over this project.
Hopefully, this way all these issues with working patches will finally be fixed.

danepowell’s picture

danepowell commented
StatusFileSize
new diff-994204-12.patch2.19 KB

Here's a version of #2 that can be applied with Git

realityloop’s picture

realityloop commented
Status: Patch (to be ported) » Fixed

fixed in dev

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.