Problem/Motivation

Source revision / Target revision radios have no label. All form element must have a label to adhere to WCAG 3.3.2, see https://www.w3.org/WAI/WCAG22/Understanding/labels-or-instructions.html

Steps to reproduce

Inspect html on /node/1/revisions:
<input data-drupal-selector="edit-node-revisions-table-0-select-column-two" type="radio" id="edit-node-revisions-table-0-select-column-two" name="radios_right" value="1" checked="checked" class="form-radio" style="display: block;">

Proposed resolution

Add a label to Source revision / Target revision radios

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

Source revision / Target revision radios have a label

API changes

None

Data model changes

None

Issue fork diff-3588984

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Issue summary: View changes

idebr opened merge request !160

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request adds a label to Source revision / Target revision radios

The generated HTML is now:

<label for="edit-node-revisions-table-1-select-column-one" class="form-item__label visually-hidden">Source revision: 1</label>
          <input data-drupal-selector="edit-node-revisions-table-1-select-column-one" type="radio" id="edit-node-revisions-table-1-select-column-one" name="radios_left" value="1" checked="checked" class="form-radio form-boolean form-boolean--type-radio" style="display: block;">
acbramley’s picture

acbramley commented
Status: Needs review » Fixed

Nice find, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • acbramley committed d04ccf68 on 2.x authored by idebr 
    fix: #3588984 Source revision / Target revision radios must have labels...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.