Problem/Motivation

When reviewing the diff for content that uses Paragraphs (or any other similar module) as components, it is difficult to understand what each field is associated with. One field could be repeated multiple times on the various referenced Paragraph entities, making the diff hard to understand.

Steps to reproduce

Review the diff for content that uses Paragraphs or any referenced entity.

Proposed resolution

Adjust the label to include relevant context.

Remaining tasks

  1. Confirm that we like the changes and there isn't a better approach.
  2. Add tests?

User interface changes

Changes the field label on the diff page.

Before:

After:

API changes

N/A

Data model changes

N/A

Issue fork diff-3487580

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

adamzimmermann created an issue. See original summary.

adamzimmermann’s picture

Issue summary: View changes
StatusFileSize
new581 bytes

If you are using the diff module with the Workspaces Extra module, you will need the patch I just uploaded to alter the service definition.

adamzimmermann’s picture

Status: Active » Needs review
acbramley’s picture

Status: Needs review » Needs work

MR is failing, will need a rebase.

adamzimmermann’s picture

Assigned: adamzimmermann » Unassigned
Status: Needs work » Needs review

Merge conflict resolved, ready for further testing.

acbramley’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

This is quite a good improvement, I've left some minor comments and I think it would be good to get some tests too.

adamzimmermann’s picture

Status: Needs work » Needs review

Changes implemented, except for the tests. Let me know if the changes align with your vision.

Tests are something I'm not very proficient at. If someone else could pick that part up that would be great.

acbramley’s picture

Status: Needs review » Needs work

Looking good, back to NW for tests