Problem/Motivation

According to @mglaman having a get method in constructor is an anti pattern since the object is not lazy loaded anymore.

Proposed resolution

Should be replaced with config.factory service.

Issue fork diff-3406948

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

zniki.ru created an issue. See original summary.

zniki.ru opened merge request !37

nikolay shapovalov’s picture

nikolay shapovalov commented
Assigned: nikolay shapovalov » Unassigned

MR is ready for review.

nikolay shapovalov’s picture

nikolay shapovalov commented
Status: Active » Needs review
heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Version: 8.x-1.x-dev » 2.x-dev
Status: Needs review » Needs work

This needs a rebase and the base of the MR needs to change to 2.x. See review https://git.drupalcode.org/project/diff#contribution-guidelines.

heddn’s picture

heddn
Primary language English
Location Nicaragua
commented
Issue tags: +Needs reroll