Needs review
Project:
Diff
Version:
2.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
20 Dec 2022 at 14:32 UTC
Updated:
3 Jun 2025 at 01:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
malcomio commentedNot sure about the approach in https://git.drupalcode.org/project/diff/-/merge_requests/25 - adding padding may be intrusive.
Comment #4
malcomio commentedComment #6
heddnCan we post some screenshots of the before/after?
Comment #7
malcomio commentedHere's how it looks:

Comment #8
heddnSeems like a relatively helpful change.
Comment #9
acbramley commentedPipeline is failing.
Comment #10
malcomio commentedThe test failures relate to PHP code sniffer issues in files that aren't being changed - this change is only a CSS change.
Have merged 2.x into this branch and pushed, and the pipeline succeeded.
Comment #11
acbramley commentedThis is looking good, however I don't think we should add the padding to non img diffs. I've added a :has selector to fix that. Here's what it looks like now: