Problem/Motivation

when I deleting a translate node, and create a new translate node again, the translation node revison will load a original language revison in the revision list.

Steps to reproduce

1、Create a english node and save as Needs Review

2、Translate to a japanese node and save as Needs Review too

3、Delete the japanese node

4、Translate to a japanese node and save as Needs Review again

5、Check reversion of japanese node
node revision

Proposed resolution

Hide the original language node revision on the translation node revison list.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 revision_overview_form_3322352.patch1.43 KBotofu
#7 revision_overview_form_3322352_7.patch1.46 KBconnbi
#6 revision_overview_form_3322352-6.patch1.72 KBrandy tang
#5 revision_overview_form_3322352-5.patch1.66 KBrandy tang
#4 revision_overview_form_3322352.patch2.17 KBconnbi
#3 revision_overview_form_3322352.patch1.24 KBconnbi
#2 revision_overview_form_3322352_1.patch1.18 KBconnbi
image-2022-07-07-18-05-35-392.png21.95 KBconnbi

Issue fork diff-3322352

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bijiaxing created an issue. See original summary.

connbi’s picture

connbi commented
StatusFileSize
new revision_overview_form_3322352_1.patch1.18 KB

I create a patch to fix this issue, add a judgement logic when build the form data.

connbi’s picture

connbi commented
StatusFileSize
new revision_overview_form_3322352.patch1.24 KB
connbi’s picture

connbi commented
StatusFileSize
new revision_overview_form_3322352.patch2.17 KB

Modify the judgement logic of current revision.

randy tang’s picture

randy tang commented
StatusFileSize
new revision_overview_form_3322352-5.patch1.66 KB

1、Go to admin/config/workflow/workflows/manage

2、Update "Content types" in "THIS WORKFLOW APPLIES TO:" and Uncheck "one content type"

3、Save the changes

4、Create a "one content type" page

5、Fill in necessary fields and saved

6、Edit "one content type" page and Click Revisions tab
It will prompt Error: Call to a member function hasTranslation() on null in Drupal\diff\Form\RevisionOverviewForm->buildForm() (line 215 of modules/contrib/diff/src/Form/RevisionOverviewForm.php).

randy tang’s picture

randy tang commented
StatusFileSize
new revision_overview_form_3322352-6.patch1.72 KB

Patch misses getting reversion translations

connbi’s picture

connbi commented
StatusFileSize
new revision_overview_form_3322352_7.patch1.46 KB

New patch for 2.0.0-beta3

otofu’s picture

otofu commented
StatusFileSize
new revision_overview_form_3322352.patch1.43 KB

New patch for 8.x-1.8

zaryab_drupal made their first commit to this issue’s fork.

zaryab_drupal opened merge request !122

zaryab_drupal’s picture

zaryab_drupal commented

Created MR for #8 please test.

zaryab_drupal’s picture

zaryab_drupal commented
Status: Active » Needs review
acbramley’s picture

acbramley commented
Version: 8.x-1.1 » 2.x-dev
Status: Needs review » Needs work

MR has conflicts.