Visual inline diff view strips out HTML5 elements

@adstokoe,

Thanks for the patch. It works well.

Hi @phenaproxima/ @miro_dietiker

I've tested the patch. It seems to be working well for HTML5. But we need to install `xemlock/htmlpurifier-html5` package before adding the patch.

So could you please review this work and include the package in composer.json.

Thanks,
Chandra

@alan-d @lhangea @juampynr

Please see https://www.drupal.org/project/diff/issues/3226910#comment-14188898.

So could you please review the work and include the package `xemlock/htmlpurifier-html5` in your composer.json.

Thanks

Ran into this as well, and the change makes sense to me.
Modified patch to include the composer requirement and remove unnecessary var declaration in constructor.

This one has the var removal I mentioned...

Note that even though the patch includes the update to composer.json to bring in the new package, if you use this patch via composer patches, it will not bring in that dependency. I think it's just how composer works. You cannot bring in a patch that adds further composer deps. So you still need to explicitly add the new package to your own composer.json until this is committed.

Patch #15 works for me. Thanks!

Re-roll for 1.1

Alternatively, the latest version of caxy/php-htmldiff now allows to completely turn off HTMLPurifier. Perhaps we can simply add a toggle to turn it off entirely? Drupal has its own filtering chain -- I don't see an overly compelling reason to add another one on the end of it.

$html_diff->getConfig()->setPurifierEnabled(FALSE);

Attaching demo patch.

To work around this and other issues, I've spun up https://drupal.org/project/diff_plus with a resolution for HTML5 elements as well as some other opinionated additions if any issue watchers would like to give it a try.

reroll

This needs to go into an MR with tests.

Along with the above mentioned things, couple of things are still getting removed
To name a few :
1. Style Attribute
2. ID's associated with Section
3. button tag
4. Attributes like aria-label, data-title, data-lity, data-toggle, aria-expanded
5. nbsp
6. iframe tag
7. Custom Data Attributes
8. Form Tag

I've tried patch from #23 and but see no improvement, the content is displayed totally broken (CSS issues). Not sure if this is because the use of layout builder, paragraphs or what. Using Drupal 10.4.4.

Disabling the purifier as suggested in #19 seems the right way to go for me. Opened an MR for it.

the MR is failing linting and still needs tests

Reroll of #22 for 8.x-1.10.